Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional metrics regarding log dispatching and committal #316

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

freddygv
Copy link
Contributor

@freddygv freddygv commented Apr 8, 2019

Background and rationale: CSL-5488

This PR adds three metrics:

  • consul.raft.leader.dispatchNumLogs (gauge) - This metric measures the number of logs committed to disk in a batch.
  • consul.raft.commitNumLogs (gauge) - This metric measures the count of logs processed for application to the FSM in a single batch.
  • consul.raft.fsm.enqueue (timer) - This metric measures the amount of time to enqueue a batch of logs for the FSM to apply.

@freddygv freddygv requested a review from mkeeler April 8, 2019 23:22
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

:shipit:

@schristoff
Copy link
Contributor

Looks great to me 🤙

@freddygv freddygv merged commit d9fe23f into master Apr 9, 2019
@freddygv freddygv deleted the csl-5488-commit-telemetry branch April 9, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants